path list optimizations

[manuyavuz]

• Uses Dir.glob instead of Find.find for faster content fetch
• Does not recalculate file system content for local pods during installation as they won't be changed by cocoapods itself anytime.

Improvements

Previous

bundle exec pod install --clean-install  10.97s user 7.97s system 96% cpu 19.628 total
bundle exec pod install  4.91s user 4.41s system 95% cpu 9.772 total

This branch

bundle exec pod install --clean-install  6.62s user 4.12s system 86% cpu 12.453 total
bundle exec pod install  3.99s user 3.60s system 88% cpu 8.587 total

[manuyavuz]

Partially fixes #9427.

[manuyavuz]

Do we need a changelog here?

[dnkoutso]

Yeah we can add a changelog entry for "Various performance optimizations around file system reads" or something like that so we can know it went through.

[dnkoutso]

Those are very nice improvement times!

[dnkoutso]

LGTM. Any tests to add here?

[dnkoutso]

oh @manuyavuz can you also target 1-9-stable branch instead since we want this for 1.9.0!

[manuyavuz]

@dnkoutso rebased onto 1-9-stable. What is our branch policy, will you cherry pick into master after merge?

[manuyavuz]

For tests, there are existing tests for escaped path logic, but there is no test for refresh_file_accessors logic. There is no test for not cleaning local pods inside pod_dir_cleaner for example.

If we want to have better coverage here, I can spend some time tonight maybe. But I'm not sure if this should go into this PR.

[dnkoutso]

@manuyavuz I take care of merging up to master so we are good for now.

[dnkoutso]

I will try this to our large project and see impact as well as ensure no regressions.

[manuyavuz]

Awesome, lmk about results!