Correctly set deployment target for non library specs even if the root spec does not specify one. #9153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
non_library_spec_deployment_target_edge_case
branch
from
2454bd8
to
5eefcf2
Compare
dnkoutso
commented
Sep 10, 2019
| @@ -753,6 +753,14 @@ module Pod | |||
| @pod_target.deployment_target_for_non_library_spec(@watermelon_spec.test_specs.first).to_s.should == '8.0' | |||
| @pod_target.deployment_target_for_non_library_spec(@watermelon_spec.app_specs.first).to_s.should == '8.0' | |||
| end | |||
|
|
|||
| it 'returns the determined deployment target even if the podspec does not explicitly specify one' do | |||
There was a problem hiding this comment.
verified this goes red without my change.
dnkoutso
changed the title
dnkoutso
force-pushed
the
non_library_spec_deployment_target_edge_case
branch
from
5eefcf2
to
4160faf
Compare
paulb777
approved these changes
Sep 10, 2019
…t spec does not specify one.
dnkoutso
force-pushed
the
non_library_spec_deployment_target_edge_case
branch
from
4160faf
to
a2d748d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment target for non library spec is explicitly used if one is specified, otherwise the code used to use the one from the parent spec. However, is it not guaranteed that the parent spec has a deployment target specified.
The
analyzersets a default deployment target if that is the case on thePodTargetitself. This PR ensures we use that if the deployment target for a non library spec isnil.