Make APPLICATION_EXTENSION_API_ONLY not break when performing a cached incremental install #9142
Conversation
igor-makarov
changed the title
igor-makarov
force-pushed
the
api-extension-with-cache
branch
from
c0e0e9f
to
c319a90
Compare
|
Needs a changelog entry |
|
cc @sebastianv1 |
|
Made the property readonly, added changelog, fixed the code comments. |
|
|
||
| next unless is_app_extension | ||
|
|
||
| aggregate_target.mark_application_extension_api_only |
There was a problem hiding this comment.
Can the logic for determining is_app_extension live inside AggregateTarget. It looks like you're only using properties off aggregate_target. This allows you to remove mark_application_extension_api_only which is kinda ugly and get rid of the default false value.
There was a problem hiding this comment.
While the logic for is_app_extension can be put in AggregateTarget, mark_application_extension_api_only cannot be done away with - PodTarget also needs to be marked and it has no idea who its parent is.
There was a problem hiding this comment.
I had a chat with @segiddins about it and it makes sense for the Analyzer to be the single one responsible for this weird flag.
|
Please add a spec for |
|
The cache analyzer worked correctly, the problem was that the app extension flag was being set after generation in some obscure corner which was bypassed in an incremental cached install. |
| extension_target.product_type = 'com.apple.product-type.watchkit2-extension' | ||
| extension_target.name = 'watchOS Extension Target' | ||
| extension_target.symbol_type.should == :watch2_extension | ||
| @user_project.save |
There was a problem hiding this comment.
does this actually leave the file system dirty after this test runs?
There was a problem hiding this comment.
It doesn't - this is a temp copy (create_sample_app_copy_from_fixture).
Closes #9141
Closes #8967