Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure real path for header_mappings_dir #12315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wjaykim
Copy link

@wjaykim wjaykim commented Mar 19, 2024

If header_mappings_dir is set to symlinked path, the header directory structure is not preserved currently because cocoapods uses header's real path to find relative path from header_mappings_dir, but header_mappings_dir is not ensured to be a real path(it could be symlinked path).

We can easily reproduce issue with following conditions:

  • React Native 0.73+: it uses header_mappings_dir in its local podspecs
  • with use_frameworks! :linkage => :static.
  • pnpm: React Native add podspecs from Node.js' node_module directory, and pnpm uses symlink to create node_module directory.

Related issue:

If header_mappings_dir is set to symlinked path, the header directory structure is not preserved currently because cocoapods uses header's real path to find relative path from header_mappings_dir, but header_mappings_dir is not ensured to be a real path(symlinked path).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant