Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation fail when Publishing iOS pods to private specs repo using Xcode 14.3. or upper #12151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tkgka
Copy link

@tkgka tkgka commented Nov 16, 2023

fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper

fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper

- validation check on iOS 12 or upper because Xcode 14.3. or upper doesn't support iOS 11 or lower
@tkgka tkgka changed the title Update analyzer.rb Fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper Nov 16, 2023
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. More is needed here:

  • Xcode 14 still supports iOS 11
  • Other platforms
  • Overriding dependency minimum options should be an option.

More discussion at #11839

@CocoaPodsBarista
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

* Fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper  
  [tkgka](https://github.com/tkgka)
  [#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

change validation target to iOS 11 or upper because Xcode 14 still support iOS 11
@tkgka
Copy link
Author

tkgka commented Nov 17, 2023

* Fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper  
  [tkgka](https://github.com/tkgka)

@paulb777

  1. change validation target(minimum deployment target) to iOS 11 or upper
  2. what platforms do you mean?
  3. can you give me more information about Overriding dependency minimum options should be an option. because it happen even I set s.ios.deployment_target = '13.0'

@tkgka
Copy link
Author

tkgka commented Nov 17, 2023

and I think people who want to deploy their library with deploayment target as 8.0 can still use lower version of the CocoaPods to deploy their library even if we update the minimum deployment target

@tkgka tkgka requested a review from paulb777 November 17, 2023 00:59
@@ -865,7 +865,7 @@ def determine_platform(specs, target_definitions, build_type)
Version.new(library_spec.deployment_target(platform_name) || default)
end.max
if platform_name == :ios && build_type.framework?
minimum = Version.new('8.0')
minimum = Version.new('11.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the wrong place in the code for this change, since this is specifying 8.0 is when Apple introduced framework support for iOS. The change should also impact tvOS, macOS, and tvOS

Copy link
Author

@tkgka tkgka Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777
does it possible to impact other OS(watchOS, macOS and tvOS)?
change only run when the platform_name is iosbecause of the top line code
if platform_name == :ios && build_type.framework?

Copy link
Author

@tkgka tkgka Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I think it right place to change because I change every singe code that determine the version 8.0 to 12.0 one by one and only place that can help was the lib/cocoapods/installer/analyzer.rb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos and tvos have the same issue as ios and should have a similar fix.

Copy link
Author

@tkgka tkgka Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777
ah now I see, but currently this fix is for iOS, so what about fix other platform's issue on the other commit? (I cannot find the source for other platform on this file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777 can you check whether it can merge or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described, this is the wrong place for managing minimum version. This code is for testing if frameworks are supported or not on iOS.

@tkgka tkgka requested a review from paulb777 November 17, 2023 13:12
@tkgka tkgka changed the title Fix validation fail when Publishing pods to private specs repo using Xcode 14.3. or upper Fix validation fail when Publishing iOS pods to private specs repo using Xcode 14.3. or upper Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants