Fix compatibility error with Ruby 3.x #11959
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CocoaPods with Ruby 3.x, and the path has non-ascii characters in it, then we may encounter the following error: ``` Encoding::CompatibilityError - incompatible character encodings: UTF-8 and ASCII-8BIT /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1564:in `join' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1564:in `join' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1224:in `path' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:500:in `block in copy_entry' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1513:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1516:in `block in wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `each' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1515:in `wrap_traverse' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:497:in `copy_entry' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:471:in `block in cp_r' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1597:in `block in fu_each_src_dest' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1613:in `fu_each_src_dest0' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:1595:in `fu_each_src_dest' /Users/uddmobile-2019/.rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/fileutils.rb:470:in `cp_r' /Users/uddmobile-2019/.rvm/gems/ruby-3.0.0/gems/cocoapods-1.12.1/lib/cocoapods/downloader.rb:55:in `block (2 levels) in download' ``` This commit aims to fix this so that users don't have to change their path to accommodate a software limitation.
|
how easy is it to add a test? |
|
Thank's for making the PR, I wasn't even aware there is compatibility with Ruby 3 in the first place. It would've been helpful if the docs would mention this. Any progress on this, btw? |
|
same error here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CocoaPods with Ruby 3.x, and the path has non-ascii characters in it, then we may encounter the following error:
This merge request aims to fix this so that users don't have to change their path to accommodate a software limitation.