Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove the cache under 'Local Podspecs' if the Pod is a local pod #11920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CrazyFanFan
Copy link

The method clean_pod skips the deletion of the cache under 'Local Podspecs' if the Pod is a local pod.

@orta
Copy link
Member

orta commented May 26, 2023

I think you probably should give us an explanation of why you're requesting this change, it's not obvious why this is correct

@CrazyFanFan
Copy link
Author

CrazyFanFan commented May 26, 2023

@orta, thank you for your reply.

In general, the cache of Local Pods under Pods/Local Podspecs is retained, except for the first time when a Pod is switched from a remote Pod to a local Pod, and only in this case is the cache file deleted. The cache file will be retained in subsequent installations.

The reason I discovered this issue is that I did some extra work using the cache files under Pods/Local Podspecs after running pod install, which resulted in some anomalies.

The objectives of this submission are twofold:

  1. To address the anomaly I encountered.
  2. Unify the behavior of local pods.

Is there any specific design goal for not retaining the cache during the first switch to a local Pod?

The above text was translated into English by AI. If there are any unclear expressions, please forgive me and point them out for me. Thank you.

@Liiiszt
Copy link

Liiiszt commented Aug 22, 2023

I think you probably should give us an explanation of why you're requesting this change, it's not obvious why this is correct

When I tried to change the reference of a third-party library, ProgressHUD, from remote to local, I encountered the following error:

Errno::ENOENT - No such file or directory @ rb_sysopen - .../workspace/Pods/Local Podspecs/ProgressHUD.podspec.json

I also noticed that the ProgressHUD.podspec.json file was initially added to the 'Local Podspecs' folder and then removed.

This commit successfully fixes the issue, and I hope it could be merged. Thanks.

@action121
Copy link

Yes, I also encountered this problem, and made local pod code modifications based on this code submission plan, which solved my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants