Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential Gatekeeper problems by removing the LD_RUNPATH_SEARCH_PATHS referencing outside the App bundle for macOS targets. (#10954) #11837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential Gatekeeper problems by removing the LD_RUNPATH_SEARCH_PATHS referencing outside the App bundle for macOS targets. (#10954) #11837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -12,7 +12,11 @@ To install release candidates run `[sudo] gem install cocoapods --pre`

##### Bug Fixes

* None.
* Fix potential Gatekeeper problems by removing the `LD_RUNPATH_SEARCH_PATHS` referencing outside the App bundle for
macOS targets.
[Ethan Wong](https://github.com/GetToSet)
[#11837](https://github.com/CocoaPods/CocoaPods/pull/11773)
[#10954](https://github.com/CocoaPods/CocoaPods/issues/10954)


## 1.12.1 (2023-04-18)
Expand Down
2 changes: 1 addition & 1 deletion lib/cocoapods/target/build_settings.rb
View file
Open in desktop
Expand Up @@ -359,7 +359,7 @@ def _ld_runpath_search_paths(requires_host_target: false, test_bundle: false, us
else
"'@loader_path/Frameworks'"
end
paths << '${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}' if uses_swift
paths << '${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}' if uses_swift && test_bundle
else
paths << "'@executable_path/Frameworks'"
paths << "'@loader_path/Frameworks'"
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/target/build_settings/aggregate_target_settings_spec.rb
View file
Open in desktop
Expand Up @@ -440,7 +440,7 @@ def pod_target(spec, target_definition)
mock_user_target = mock('usertarget')
mock_user_target.stubs(:symbol_type).returns(:application)
@target.stubs(:user_targets).returns([mock_user_target])
@generator.generate.to_hash['LD_RUNPATH_SEARCH_PATHS'].should == %q[$(inherited) /usr/lib/swift '@executable_path/../Frameworks' '@loader_path/Frameworks' "${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}"]
@generator.generate.to_hash['LD_RUNPATH_SEARCH_PATHS'].should == "$(inherited) /usr/lib/swift '@executable_path/../Frameworks' '@loader_path/Frameworks'"
end

it 'uses the target definition swift version' do
Expand Down