Fix setting LD_RUNTIME_SEARCH_PATHS for aggregate targets that include dynamic xcframeworks.
#11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
fix_other_ld_runtime_paths
branch
from
071be88
to
bfc6506
Compare
…ude dynamic xcframeworks.
dnkoutso
force-pushed
the
fix_other_ld_runtime_paths
branch
from
bfc6506
to
58cc35d
Compare
dnkoutso
commented
Jan 14, 2022
|
|
||
| it 'includes default runpath search path list when linking vendored dynamic xcframework' do | ||
| @target.stubs(:build_type => BuildType.dynamic_framework) | ||
| @generator.generate.to_hash['LD_RUNPATH_SEARCH_PATHS'].should == "$(inherited) '@executable_path/Frameworks' '@loader_path/Frameworks'" |
There was a problem hiding this comment.
verified this fails without my change.
amorde
approved these changes
Jan 14, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app (and its aggregate target) only consume pre-built dynamic xcframeworks (xcframeworks with slices that are dynamically linked) then we never set the
LD_RUNTIME_SEARCH_PATHSbecause we only do it if any of our dependencies are dynamic or whether vendored frameworks are dynamic.This PR fixes this.