Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider podspec_repo when analying sandbox for changes. #10985

Merged
merged 1 commit into from Mar 8, 2022

Conversation

dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Oct 4, 2021

This PR landed for 1.11.x release #10825 which caused a side-effect in which pods inside the Podfile with explicit source set are not matching the sandbox manifest.

It seems the sandbox manifest does not load the spec repo when parsing dependencies from the Manifest.lock file.

@igor-makarov
Copy link
Contributor

@dnkoutso @amorde I've looked into some odd behavior with a pod I'm installing from a 3rd-party spec repo.

My investigation led me to this PR - I believe this needs to go into the upcoming 1.11.x release.

This change looks correct!

@dnkoutso dnkoutso added this to the 1.11.3 milestone Mar 8, 2022
@dnkoutso dnkoutso closed this Mar 8, 2022
@dnkoutso dnkoutso reopened this Mar 8, 2022
@dnkoutso dnkoutso merged commit 65860b2 into CocoaPods:1-11-stable Mar 8, 2022
@dnkoutso dnkoutso deleted the fix_sandbox_analyzer branch March 10, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants