Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Attempt fix 10430 #10856

Closed
wants to merge 1 commit into from

Conversation

dnkoutso
Copy link
Contributor

Maybe closes #10430

@dnkoutso dnkoutso added this to the 1.11.0 milestone Aug 11, 2021
@CocoaPodsBarista
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

* [WIP] Attempt fix 10430  
  [dnkoutso](https://github.com/dnkoutso)
  [#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@dnkoutso
Copy link
Contributor Author

integration tests will fail but I am curious on examples if they are passing.

@dnkoutso
Copy link
Contributor Author

ok good examples pass with this change.

will chat offline to see if this is the right fix after I understand our scripts more and if this change might cause any regressions.

@dnkoutso dnkoutso closed this Aug 11, 2021
@dnkoutso
Copy link
Contributor Author

talked offline, we should not do this despite the fact the examples passed.

@dnkoutso dnkoutso deleted the attempt_fix_10430 branch August 11, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants