Bump minimum version of Xcodeproj to 1.19.0 #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Bump minimum version of Xcodeproj to 1.19.0
[dnkoutso](https://github.com/dnkoutso)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
amorde
approved these changes
Oct 20, 2020
segiddins
approved these changes
Oct 20, 2020
dnkoutso
force-pushed
the
bump_xcodeproj119
branch
from
4597752
to
553e4ed
Compare
dnkoutso
commented
Oct 20, 2020
| if platform == :osx | ||
| configuration.build_settings['CODE_SIGN_IDENTITY'] = '' | ||
| elsif platform == :ios | ||
| configuration.build_settings['CODE_SIGN_IDENTITY'] = 'iPhone Developer' |
There was a problem hiding this comment.
the default now is nil from Xcode 12 build settings. I decided to maintain what we used to do.
dnkoutso
force-pushed
the
bump_xcodeproj119
branch
from
553e4ed
to
0de99e7
Compare
dnkoutso
force-pushed
the
bump_xcodeproj119
branch
from
0de99e7
to
b3ae4b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration specs: CocoaPods/cocoapods-integration-specs#303