Skip to content

Commit

Permalink
Apply correct SYSTEM_FRAMEWORK_SEARCH_PATHS for XCTUnwrap fix.
Browse files Browse the repository at this point in the history
  • Loading branch information
dnkoutso committed Mar 2, 2020
1 parent f30d0aa commit e5f0de5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -12,6 +12,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`

##### Bug Fixes

* Apply correct `SYSTEM_FRAMEWORK_SEARCH_PATHS` for `XCTUnwrap` fix.
[Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#9579](https://github.com/CocoaPods/CocoaPods/pull/9579)

* Fix an issue that caused a build failure with vendored XCFrameworks on macOS
[Eric Amorde](https://github.com/amorde)
[#9572](https://github.com/CocoaPods/CocoaPods/issues/9572)
Expand Down
2 changes: 1 addition & 1 deletion lib/cocoapods/target/build_settings.rb
Expand Up @@ -691,7 +691,7 @@ def initialize(target, non_library_spec = nil, configuration: nil)

# @return [Array<String>]
define_build_settings_method :system_framework_search_paths, :build_setting => true, :memoized => true, :sorted => true, :uniqued => true do
return ['$(PLATFORM_DIR)/Developer/usr/lib'] if should_apply_xctunwrap_fix?
return ['$(PLATFORM_DIR)/Developer/Library/Frameworks'] if should_apply_xctunwrap_fix?
[]
end

Expand Down
4 changes: 2 additions & 2 deletions spec/unit/target/build_settings/pod_target_settings_spec.rb
Expand Up @@ -189,7 +189,7 @@ class BuildSettings
@pod_target.stubs(:platform).returns(Platform.new(:ios, '12.1'))
generator = PodTargetSettings.new(@pod_target, nil, :configuration => :debug)
hash = generator.generate.to_hash
hash['SYSTEM_FRAMEWORK_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
hash['SYSTEM_FRAMEWORK_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/Library/Frameworks"'
hash['LIBRARY_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
hash['SWIFT_INCLUDE_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
end
Expand All @@ -199,7 +199,7 @@ class BuildSettings
@pod_target.stubs(:platform).returns(Platform.new(:ios, '12.1'))
generator = PodTargetSettings.new(@pod_target, nil, :configuration => :debug)
hash = generator.generate.to_hash
hash['SYSTEM_FRAMEWORK_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
hash['SYSTEM_FRAMEWORK_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/Library/Frameworks"'
hash['LIBRARY_SEARCH_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
hash['SWIFT_INCLUDE_PATHS'].should.include '"$(PLATFORM_DIR)/Developer/usr/lib"'
end
Expand Down

0 comments on commit e5f0de5

Please sign in to comment.