Merge pull request #10483 from igor-makarov/remove-block-length

disable `Metrics/BlockLength`
CocoaPods · Mar 2, 2021 · b16c090 · b16c090
2 parents 592761b + f1a4a8b
commit b16c090
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.rubocop_cocoapods.yml b/.rubocop_cocoapods.yml
@@ -57,6 +57,11 @@ GuardClause:
 Next:
   Enabled: false
 
+# Arbitrary max lengths for classes simply do not work and enabling this will
+# lead to a never ending stream of annoyance and changes.
+Metrics/BlockLength:
+  Enabled: false
+
 # Arbitrary max lengths for classes simply do not work and enabling this will
 # lead to a never ending stream of annoyance and changes.
 Metrics/ClassLength:

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -234,11 +234,6 @@ Lint/UriRegexp:
 Lint/UselessAccessModifier:
   Enabled: false
 
-# Offense count: 373
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 1476
-
 # Offense count: 7099
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

diff --git a/spec/unit/installer/analyzer_spec.rb b/spec/unit/installer/analyzer_spec.rb
@@ -1,8 +1,8 @@
 require File.expand_path('../../../spec_helper', __FILE__)
 
 module Pod
-  describe Installer::Analyzer do # rubocop:disable Metrics/BlockLength
-    describe 'Analysis' do # rubocop:disable Metrics/BlockLength
+  describe Installer::Analyzer do
+    describe 'Analysis' do
       before do
         repos = [Source.new(fixture('spec-repos/test_repo')), TrunkSource.new(fixture('spec-repos/trunk'))]
         aggregate = Pod::Source::Aggregate.new(repos)