New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix# 1982: Loading YAML Safely #1983
Conversation
@RishabhJain2018 @deshraj Please Review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkartik97 This looks good though! Can you please add a link to the PR or the documentation in the description where it says PyYAML 4 loads the data safely by default
.
This PyYAML 4.2 Release Plan acts on reverting the PR : Make pyyaml safe by default. #74 which is still not closed. This, the commit Loading YAML Safely in this PR deals with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Fixes: #1982
Updated PyYaml to 4.2b1
Directly Updated to 4.2b1 as 4.1 was retracted
Also, replaced
yaml.load()
withyaml.safe_load()
in apps/challenges/views.py#L566Edit: This PyYAML 4.2 Release Plan acts on reverting the PR : Make pyyaml safe by default. #74 which is still not closed.
This, the commit Loading YAML Safely in this PR deals with this.