Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize query params before logging #69

Merged
merged 2 commits into from Oct 6, 2020

Conversation

ulziibay
Copy link
Contributor

@ulziibay ulziibay commented Oct 2, 2020

Flare-1008

Overview

This adds query parameter name sanitization based on qs library's allowPrototypes : false option that is resistant to prototype pollution attack. More on qs: ljharb/qs#98 and ljharb/qs#200.

More on the attack: https://github.com/HoLyVieR/prototype-pollution-nsec18

@pickabot pickabot bot requested a review from aastein October 2, 2020 23:08
@pickabot pickabot bot requested a review from ghirsch1 October 2, 2020 23:08
test/middleware.ts Show resolved Hide resolved
@ulziibay
Copy link
Contributor Author

ulziibay commented Oct 5, 2020

@ghirsch1 i just bumped the version. Is there any thing I have to do to publish this?

@ulziibay ulziibay merged commit 76c074f into master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants