Fix bug where one AD group would be added as one char groups #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the AD returns "group" claim as a string instead of a list of strings the update_ad_groups function would add every char in the group name as a separate ADGroup. Fixed by converting the string to a one element list of the string before calling user.update_ad_groups.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
+ Coverage 80.23% 80.24% +0.01%
===========================================
Files 90 90
Lines 3764 3766 +2
===========================================
+ Hits 3020 3022 +2
Misses 744 744
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akikoskinen
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the AD returns "group" claim as a string instead of a list of strings the update_ad_groups function would add every char in the group name as a separate ADGroup.
Fixed by converting the string to a one element list of the string before calling user.update_ad_groups.
Refs HP-1953