Merge latest develop to master #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sub value can be changed by setting a value to a setting named "SOCIAL_AUTH_DUMMYFIXEDOIDCBACKEND_SUB_VALUE"
If nothing to do.
When the user was logged in with a backend that is in the ALWAYS_REAUTHENTICATE_BACKENDS setting, there could be a case where another log in with the same backend but with a different user would add a second social auth to the user. It happened if the user was still logged in to Tunnistamo but logged out of the backend.
sqlparse had one vulnerability: GHSA-rrm6-wvj7-cwh2
django had one vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2023-31047
requests had one vulnerability: GHSA-j8r2-6x86-q33q
pillow had one vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-PILLOW-5489784
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 80.06% 80.23% +0.16%
==========================================
Files 90 90
Lines 3753 3764 +11
==========================================
+ Hits 3005 3020 +15
+ Misses 748 744 -4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akikoskinen
previously approved these changes
May 25, 2023
clean_attributes function tried to call split function on None. That was because if "unique_name" was not in attrs_in the attribute mapping would set attrs['last_first_name'] to None and the following code only checked that the key exists in the dict before using attrs['last_first_name'] as a string.
|
Kudos, SonarCloud Quality Gate passed!
|
akikoskinen
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.