Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Javascript dependencies #221

Merged
merged 2 commits into from Mar 1, 2022
Merged

Lock Javascript dependencies #221

merged 2 commits into from Mar 1, 2022

Commits on Mar 1, 2022

  1. Lock Javascript dependencies

    It's a good practice to lock dependency versions. But there's a specific
    reason why this needs to be done now.
    
    Tunnistamo isn't compatible with bootstrap-sass version 3.4.2. That
    version switches [1] to a newish Sass syntax that isn't backwards
    compatible [2]. Tunnistamo uses the django-sass-processor package to do
    Sass preprocessing. That package uses the libsass library, which is
    deprecated and will never support any newer Sass syntax [3]. As a
    result, Tunnistamo is stuck with an old Sass syntax version unless the
    preprocessor system is changed to something more modern.
    
    In this commit the bootstrap-sass is locked to version 3.4.1 which still
    uses the older syntax that libsass supports.
    
    [1] twbs/bootstrap-sass#1221
    [2] https://sass-lang.com/documentation/breaking-changes/slash-div
    [3] https://sass-lang.com/blog/libsass-is-deprecated
    akikoskinen committed Mar 1, 2022
    Copy the full SHA
    f9c5b18 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    297b5a0 View commit details
    Browse the repository at this point in the history