Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hds 2017 header docs fixes #1194

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Conversation

harriplappalainen
Copy link
Contributor

Description

Fixes to Header docs such as broken links, missing props.

Related Issue

https://helsinkisolutionoffice.atlassian.net/browse/HDS-2017

How Has This Been Tested?

Localhost
Demo

@harriplappalainen harriplappalainen requested a review from a team December 20, 2023 11:41
@Riippi
Copy link
Contributor

Riippi commented Dec 21, 2023

Header.ActionBar onMenuButtonClick should be onMenuClick ?
Edit. Seems that this is already changed in the other header PR.

site/src/docs/components/header/index.mdx Outdated Show resolved Hide resolved
site/src/docs/components/header/index.mdx Outdated Show resolved Hide resolved
site/src/docs/components/header/index.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@harriplappalainen harriplappalainen merged commit bc94245 into development Dec 29, 2023
6 checks passed
@harriplappalainen harriplappalainen deleted the hds-2017-header-docs-fixes branch December 29, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants