bug: Fixed notification when the user or project is deleted #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| def name | ||
| "Deleted User" | ||
| end | ||
| end |
There was a problem hiding this comment.
end at 7, 2 is not aligned with class at 3, 0.
| end | ||
| end | ||
|
|
||
| class DeletedProject |
There was a problem hiding this comment.
Inconsistent indentation detected.
| # app/models/null_objects.rb | ||
|
|
||
| class DeletedUser | ||
| def name |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
| "Deleted User" | ||
| end | ||
| end | ||
|
|
| "Deleted Project" | ||
| end | ||
| end | ||
|
|
| @@ -0,0 +1,14 @@ | |||
| # app/models/null_objects.rb | |||
There was a problem hiding this comment.
Missing frozen string literal comment.
|
Code Climate has analyzed commit f946c95 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Describe the changes you have made in this PR -
I deleted the old part of code and implemented the null object pattern in ForkNotification class.
I added a file (deleted_objects.rb) where i defined the null objects: deleted user and deleted project.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.