Do not check contention on downstream values #4903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We define an output node value to be upstream if it is given to it by its parent element. All other values are downstream values. In the case that a node gives an output node value (while the parent does not drive the output value. e.g. Tristate with control bit 0), and then the same node gives another value to the output node, earlier it would cause contention since the output node is said to [before the propagation from the other node] still have the former value. This is a downstream value and post this commit will be overwritten. Contention will only be checked at upstream valued output nodes.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -103,6 +103,8 @@ export default class AndGate extends CircuitElement { | |||
| result &= this.inp[i].value || 0; | |||
| this.output1.value = result >>> 0; | |||
| simulationArea.simulationQueue.add(this.output1); | |||
|
|
|||
| @@ -82,6 +82,8 @@ export default class Buffer extends CircuitElement { | |||
|
|
|||
| this.output1.value = this.state; | |||
| simulationArea.simulationQueue.add(this.output1); | |||
|
|
|||
| } | ||
|
|
||
| /** | ||
| * @memberof ConstantVal | ||
| * updates state using a prompt when dbl clicked | ||
| */ | ||
| dblclick() { | ||
| this.state = prompt("Re enter the value") || "0"; | ||
| const state_ = prompt("Re enter the value") || "0"; |
There was a problem hiding this comment.
Unexpected dangling '' in 'state'.
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { |
There was a problem hiding this comment.
Expected 'this' to be used by class method 'isValidState'.
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { | ||
| for (const c of state) |
There was a problem hiding this comment.
iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { | ||
| for (const c of state) |
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { | ||
| for (const c of state) | ||
| if (c != "0" && c != "1") return false; |
There was a problem hiding this comment.
Expected no linebreak before this statement.
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { | ||
| for (const c of state) | ||
| if (c != "0" && c != "1") return false; |
There was a problem hiding this comment.
Expected '!==' and instead saw '!='.
| this.newBitWidth(this.state.toString().length); | ||
| } | ||
|
|
||
| isValidState(state) { | ||
| for (const c of state) | ||
| if (c != "0" && c != "1") return false; |
There was a problem hiding this comment.
Expected '!==' and instead saw '!='.
| @@ -232,6 +232,8 @@ export default class RGBLedMatrix extends CircuitElement { | |||
| colors[rowNodeValue][columnNodeValue] = colorValue; | |||
| } | |||
| } | |||
|
|
|||
|
Code Climate has analyzed commit 6c369c0 and detected 25 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define an output node value to be upstream if it is given to it by its parent element. All other values are downstream values.
In the case that a node gives an output node value (while the parent does not drive the output value. e.g. Tristate with control bit 0), and then the same node gives another value to the output node, earlier it would cause contention since the output node is said to [before the propagation from the other node] still have the former value.
This is a downstream value and post this commit will be overwritten. Contention will only be checked at upstream valued output nodes.