Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Design For Footer #4563

Open
Asrani-Aman opened this issue Jan 10, 2024 · 10 comments · May be fixed by #4846
Open

Improved Design For Footer #4563

Asrani-Aman opened this issue Jan 10, 2024 · 10 comments · May be fixed by #4846
Assignees

Comments

@Asrani-Aman
Copy link
Member

Asrani-Aman commented Jan 10, 2024

Is your feature request related to a problem? Please describe

Revamping the Footer Section
1.Arranging the uneven Margin
2.adding hover effect on the links for the better user experience

Describe the solution you'd like

Revamping the Footer Section

Attaching the Figma Link

https://www.figma.com/file/656lhewR01Ax4C7QiNAPZY/Untitled?type=design&node-id=0%3A1&mode=design&t=NFQ6vXJBjKEuXnm9-1

BEFORE DEKTOP VIEW FOOTER DESIGN
Screenshot 2024-01-09 at 10 09 52 AM

After Desktop View Footer Design

Screen.Recording.2024-01-10.at.10.32.24.PM.mov

Before Mobile View
Screenshot 2024-01-10 at 10 49 53 PM

After Mobile View

Screen.Recording.2024-01-10.at.10.58.48.PM.mov

Describe alternatives you've considered

No response

Additional context

No response

Are you working on this?

Yes

@Asrani-Aman
Copy link
Member Author

@tanmoysrt sir @Prerna-0202 ma'am @tachyons sir can i work on this issue?

@tanmoysrt tanmoysrt added the ux label Jan 11, 2024
@nitin10s
Copy link
Member

nitin10s commented Jan 22, 2024

Nice spot, we removed a couple of logos from the footer which left it looking uneven. Yes, the desktop new design makes sense. Also, the mobile view is correct in the current one itself, let's not change it.

@nitin10s
Copy link
Member

Also, check these discrepancies: https://circuitverse-team.slack.com/archives/CQ17325A5/p1705214789678159

@Asrani-Aman
Copy link
Member Author

Asrani-Aman commented Jan 22, 2024

@nitin10s sir @tanmoysrt sir so should i start working for the desktop design? if yes, can you please assign this issue to me

@upsaurav12
Copy link
Contributor

upsaurav12 commented Jan 23, 2024

@nitin10s @Asrani-Aman i think can put logps(not sponsor logo) to the right of the of thr circuitVerse logo for mobile view because there is empty space in the right of the circuitverse logo which is not looking good

i think there is useless space in the right of the sponsor logo in we can utilize that space for other two containers (circuitverse , links)

@Asrani-Aman
Copy link
Member Author

@tanmoysrt bhaiya @nitin10s bhaiya , for the desktop view should I make a PR as you said above ,
and i have just add a one more design for the footer in the same Figma Link

bhaiya, can you please suggest which one is better ?

@tanmoysrt
Copy link
Member

@tanmoysrt bhaiya @nitin10s bhaiya , for the desktop view should I make a PR as you said above , and i have just add a one more design for the footer in the same Figma Link

bhaiya, can you please suggest which one is better ?

I have missed this issue.
You can raise PR

@tanmoysrt
Copy link
Member

1st design looks simple.

@Asrani-Aman
Copy link
Member Author

@tanmoysrt bhaiya, so i should work on first design or second design?

@tanmoysrt
Copy link
Member

@tanmoysrt bhaiya, so i should work on first design or second design?

Design of Frame 10 & 20 looks good, you can go with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants