Move is_bit_set into match body #339
Open
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5963865831
💛 - Coveralls |
arvidn
reviewed
Sep 12, 2023
| @@ -475,8 +475,7 @@ impl<'a, D: Dialect> RunProgramContext<'a, D> { | |||
| if cost > effective_max_cost { | |||
| return err(max_cost_ptr, "cost exceeded"); | |||
| } | |||
| let top = self.op_stack.pop(); | |||
| let op = match top { | |||
| let op = match self.op_stack.pop() { | |||
There was a problem hiding this comment.
I suspect this whole loop should probably be turned into something like:
while let Some(op) = self.op_stack.pop() {
...
}
as long as we can ensure the cost check is still performed in the edge case of it exceeding on the last operator
|
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move is_bit_set into match body.