Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIP-0025: Chialisp Message Conditions #98

Merged
merged 19 commits into from May 14, 2024
Merged

Conversation

danieljperry
Copy link
Contributor

No description provided.

@danieljperry danieljperry changed the title Open PR for message conditions CHIP CHIP-0025: Chialisp Message Conditions Jan 31, 2024
@danieljperry
Copy link
Contributor Author

This CHIP is now a Draft. It introduces a new set of Chialisp conditions to ensure that an exact set of coins is spent together. This CHIP is still in an early stage, where the conditions are described, but not yet implemented in code. Feel free to leave a review here, and follow along as more updates are added to this PR in the coming weeks.

@danieljperry
Copy link
Contributor Author

We have made some rather large updates to the message conditions and how they work. There are now only two conditions: one for sending messages, and one for receiving them. They use a six-bit bitmask to communicate the type of message to send/receive. Let us know what you think!

@danieljperry
Copy link
Contributor Author

On March 12, we will have a public Zoom call to discuss this CHIP. See the #chips channel in our discord for more details.

@danieljperry
Copy link
Contributor Author

This CHIP is being implemented in PR #430 of the chia_rs repository.

@trepca
Copy link

trepca commented Mar 12, 2024

lgtm 👌

(I missed the requirement for messages to be consumed before)

@danieljperry
Copy link
Contributor Author

Please see this Youtube video of our discussion of this CHIP with the community:
https://youtu.be/zCuP_mo3Z7s

@danieljperry
Copy link
Contributor Author

This CHIP is now in Review. Please make your final reviews soon. Note that the chia-blockchain PR and fork activation height are still pending.

@danieljperry
Copy link
Contributor Author

A couple updates for this CHIP:

  1. We have decided to allow all eight bitmask combinations in both mempool mode and in the consensus. Previously we had excluded amount and none from the mempool, but allowed them in the consensus. We are adding these combinations because there are likely legitimate use cases for them, and because it should be less confusing when everything is allowed.
  2. We have set 5 550 000 as the tentative block height for the soft fork.

@danieljperry
Copy link
Contributor Author

We have decided to push back the fork point for this CHIP to block 5 650 000.

@danieljperry
Copy link
Contributor Author

danieljperry commented Mar 29, 2024

One minor change -- we changed the name of the fork to soft fork 4. The previous name, soft fork 3, had been used in a different fork. We renamed this fork in order to avoid confusion between the two.

Please get your final reviews in, as this CHIP will be moved to Last Call soon.

@danieljperry
Copy link
Contributor Author

We have adjusted the activation height for this CHIP to block 5 716 000.

@danieljperry
Copy link
Contributor Author

This CHIP is now in Last Call. If no changes are required for the next two weeks, it will be moved to Final.

@danieljperry
Copy link
Contributor Author

This CHIP is now Final. No further changes are allowed. The conditions introduced in this CHIP will become available after the soft fork activates, which is expected to occur around July 31, 2024. The exact block height of the activation is 5 716 000.

@danieljperry danieljperry enabled auto-merge (squash) May 14, 2024 00:21
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@danieljperry danieljperry merged commit ba50797 into main May 14, 2024
2 checks passed
@danieljperry danieljperry deleted the message_conditions branch May 14, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants