Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearqfbwjb #78

Closed
wants to merge 3 commits into from
Closed

Clearqfbwjb #78

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b111b2
make sure qfb is zeroed out
wjblanke May 12, 2021
f175a51
make sure qfb is zeroed out
wjblanke May 12, 2021
6598476
make sure qfb is zeroed out
wjblanke May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nucomp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void qfb_nucomp(qfb_t r, const qfb_t f, const qfb_t g, mpz_t& D, mpz_t& L)

// a = b * c
void nucomp_form(form &a, form &b, form &c, integer &D, integer &L) {
qfb fr, fr2, fr3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it it occurred to me this morning; do we ever want to declare qfb objects that are uninitialized? If not, we should just do this in its constructor and rest assured we won't have this problem again.

qfb fr{}, fr2{}, fr3{};

*fr.a = *a.a.impl;
*fr.b = *a.b.impl;
Expand Down Expand Up @@ -327,7 +327,7 @@ void qfb_nudupl(qfb_t r, qfb_t f, mpz_t D, mpz_t L)
// a = b * b
void nudupl_form(form &a, form &b, integer &D, integer &L)
{
qfb fr, fr2;
qfb fr{}, fr2{};

*fr.a = *a.a.impl;
*fr.b = *a.b.impl;
Expand Down