Fixing VDF prover for high difficulty #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchirica
reviewed
Aug 15, 2022
arvidn
reviewed
Sep 23, 2022
Co-authored-by: Arvid Norberg <arvid.norberg@gmail.com>
Co-authored-by: Arvid Norberg <arvid.norberg@gmail.com>
fchirica
approved these changes
Sep 26, 2022
arvidn
reviewed
Oct 3, 2022
| for (uint64_t i = 0; i < num_iterations; i++) { | ||
| if (i % kl == 0) { | ||
| uint64_t index = i / kl; | ||
| intermediates.at(index) = y; |
There was a problem hiding this comment.
using at() here will slow this down.
|
here's a somewhat tweaked and signed version of this patch: #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VDFs with difficulty higher than INT_MAX (2147483647) fail even if the difficulty is set as a double. This is because of a int loop on the difficulty in the prover_slow.h file.
Linked to issue #125