Proving draft #347
Draft
Proving draft #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional consistency changes and. avoid blocking decompressor context queue when doing qualities.
Fixes race condition on prover_disk
schinzelh
reviewed
Mar 16, 2023
| // Given a challenge, returns a quality string, which is sha256(challenge + 2 adjecent x | ||
| // values), from the 64 value proof. Note that this is more efficient than fetching all 64 x | ||
| // values, which are in different parts of the disk. | ||
| std::vector<LargeBits> GetQualitiesForChallenge(const uint8_t* challenge) | ||
| { | ||
| std::vector<LargeBits> qualities; | ||
|
|
||
| std::lock_guard<std::mutex> l(_mtx); | ||
| uint32_t p7_entries_size = 0; |
There was a problem hiding this comment.
Does p7_entries_size actually get used anywhere?
Fix Windows support
|
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.