Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier to the CI workflows #505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Prettier to the CI workflows #505

wants to merge 2 commits into from

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented May 7, 2024

No description provided.

Copy link

socket-security bot commented May 7, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/prettier@3.2.5 environment, filesystem, unsafe 0 8.39 MB prettier-bot

View full report↗︎

@Rigidity Rigidity requested a review from arvidn May 7, 2024 14:17
@Rigidity Rigidity marked this pull request as ready for review May 7, 2024 14:18
Copy link

Pull Request Test Coverage Report for Build 8986872099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 88 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.218%

Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/fullblock.rs 1 0.0%
crates/chia-protocol/src/end_of_sub_slot_bundle.rs 1 0.0%
crates/chia-protocol/src/unfinished_block.rs 1 0.0%
crates/chia-protocol/src/sub_epoch_summary.rs 1 0.0%
crates/chia-protocol/src/coin_state.rs 1 0.0%
crates/chia-protocol/src/peer_info.rs 1 0.0%
crates/chia-protocol/src/header_block.rs 1 0.0%
crates/chia-protocol/src/unfinished_header_block.rs 1 0.0%
crates/chia-protocol/src/proof_of_space.rs 1 0.0%
crates/chia-protocol/src/pool_target.rs 1 0.0%
Totals Coverage Status
Change from base Build 8908521951: -0.6%
Covered Lines: 11735
Relevant Lines: 13934

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented May 8, 2024

when I run pre-commit run --all in this branch, I get this:

[warn] README.html
[warn] wasm/pkg/chia_wasm_bg.js
[warn] wasm/pkg/chia_wasm.d.ts
[warn] wasm/pkg/chia_wasm.js
[warn] Code style issues found in 4 files. Run Prettier to fix.

the output gets messed up as there appears to be some carriage returns and newlines in there. It seems the command fails though.

@arvidn
Copy link
Contributor

arvidn commented May 8, 2024

$ echo $?
1

@Rigidity
Copy link
Contributor Author

Rigidity commented May 9, 2024

when I run pre-commit run --all in this branch, I get this:

[warn] README.html
[warn] wasm/pkg/chia_wasm_bg.js
[warn] wasm/pkg/chia_wasm.d.ts
[warn] wasm/pkg/chia_wasm.js
[warn] Code style issues found in 4 files. Run Prettier to fix.

the output gets messed up as there appears to be some carriage returns and newlines in there. It seems the command fails though.

It passes for me, perhaps it's an auto-CRLF issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants