Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more derives and constructors for various types #504

Closed
wants to merge 3 commits into from
Closed

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented May 7, 2024

The following changes have been made:

  • Derive Copy for PublicKey
  • Derive Copy for most puzzle types
  • Derive Arbitrary under the arbitrary feature for all puzzle types
  • Add constructors to most puzzles, solutions, and types (primarily with 3 or fewer arguments)
  • Simplify derive_synthetic to use DEFAULT_HIDDEN_PUZZLE_HASH by default
  • Add helper methods to enum types
  • Add missing settlement payments (offer) types

@Rigidity Rigidity requested a review from arvidn May 7, 2024 00:45
Copy link

Pull Request Test Coverage Report for Build 8977837680

Details

  • 20 of 225 (8.89%) changed or added relevant lines in 10 files are covered.
  • 90 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-1.8%) to 83.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-bls/src/public_key.rs 5 7 71.43%
crates/chia-puzzles/src/puzzles/did.rs 0 2 0.0%
crates/chia-puzzles/src/puzzles/cat.rs 1 19 5.26%
crates/chia-puzzles/src/puzzles/standard.rs 0 19 0.0%
crates/chia-puzzles/src/puzzles/singleton.rs 0 21 0.0%
crates/chia-puzzles/src/puzzles/nft.rs 0 46 0.0%
crates/chia-puzzles/src/proof.rs 0 47 0.0%
crates/chia-puzzles/src/puzzles/offer.rs 0 50 0.0%
Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/fullblock.rs 1 0.0%
crates/chia-protocol/src/end_of_sub_slot_bundle.rs 1 0.0%
crates/chia-protocol/src/unfinished_block.rs 1 0.0%
crates/chia-protocol/src/sub_epoch_summary.rs 1 0.0%
crates/chia-protocol/src/coin_state.rs 1 0.0%
crates/chia-protocol/src/peer_info.rs 1 0.0%
crates/chia-protocol/src/header_block.rs 1 0.0%
crates/chia-protocol/src/unfinished_header_block.rs 1 0.0%
crates/chia-protocol/src/proof_of_space.rs 1 0.0%
crates/chia-protocol/src/pool_target.rs 1 0.0%
Totals Coverage Status
Change from base Build 8908521951: -1.8%
Covered Lines: 11739
Relevant Lines: 14137

💛 - Coveralls

@Rigidity
Copy link
Contributor Author

Rigidity commented May 7, 2024

Going to split this PR up

@Rigidity Rigidity marked this pull request as draft May 7, 2024 14:28
@Rigidity
Copy link
Contributor Author

Replaced with other PRs

@Rigidity Rigidity closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant