Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OwnedBytes and SizedBytes to clvm-utils #499

Closed
wants to merge 2 commits into from

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity requested a review from arvidn April 29, 2024 18:22
Copy link

coveralls-official bot commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8896470441

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 70 of 98 (71.43%) changed or added relevant lines in 2 files are covered.
  • 43 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.705%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/clvm-utils/src/owned_atom.rs 34 46 73.91%
crates/clvm-utils/src/sized_atom.rs 36 52 69.23%
Files with Coverage Reduction New Missed Lines %
crates/chia-consensus/src/gen/owned_conditions.rs 3 91.3%
crates/chia-consensus/src/error.rs 3 0.0%
wheel/src/run_generator.rs 7 71.79%
crates/chia-bls/src/signature.rs 11 95.96%
crates/chia-bls/src/gtelement.rs 19 59.79%
Totals Coverage Status
Change from base Build 8882765605: -0.1%
Covered Lines: 11846
Relevant Lines: 13985

💛 - Coveralls

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected this crate to contain traits, and that the concrete implementations would be defined in some other crate

@Rigidity
Copy link
Contributor Author

I would have expected this crate to contain traits, and that the concrete implementations would be defined in some other crate

Should these go in clvm-utils?

@Rigidity Rigidity requested a review from arvidn April 30, 2024 14:23
@Rigidity Rigidity changed the title Add OwnedBytes and SizedBytes to clvm-traits Add OwnedBytes and SizedBytes to clvm-utils Apr 30, 2024
@Rigidity
Copy link
Contributor Author

These might be too redundant with chia-protocol, I'll hold off on this for now.

@Rigidity Rigidity marked this pull request as draft May 11, 2024 04:27
@Rigidity Rigidity closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants