Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include windows coverage #13587

Merged
merged 16 commits into from Jan 6, 2023
Merged

include windows coverage #13587

merged 16 commits into from Jan 6, 2023

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Oct 3, 2022 •
edited

nedbat/coveragepy#991

Draft for:

  • See if it works
  • If it does, wait for it to be released

@altendky altendky mentioned this pull request Oct 3, 2022
Closed
@altendky altendky added Added Required label for PR that categorizes merge commit message as "Added" for changelog CI CI changes labels Dec 4, 2022
@altendky altendky changed the title try out proposed windows coverage combining fix update coverage, include windows coverage Dec 24, 2022
@altendky altendky marked this pull request as ready for review December 24, 2022 17:10
@altendky altendky requested a review from a team as a code owner December 24, 2022 17:10
@altendky altendky requested a review from emlowe December 24, 2022 17:11
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky changed the title update coverage, include windows coverage include windows coverage Jan 3, 2023
emlowe
emlowe approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@wallentx wallentx merged commit e0fc986 into main Jan 6, 2023
@wallentx wallentx deleted the test_coverage_991 branch January 6, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog CI CI changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@altendky @emlowe @wallentx