Adding Walletconnect endpoints for DIDs, Datalayer, and NFT Bulk Mint #2308
Conversation
|
I also added an endpoint to allows an app to request permissions for a list commands. This would make for a much better user experience for dapps that require use of many commands, as the user can just be prompted once, at app launch to give permissions for all of the basic, read-only commands that it needs. This includes a new confirm dialog, which could probably be improved, but it does the job. If the app already has all of the permissions in the list, the command returns successful without prompting the user. If the command list sent by the app contains a command that does not allow bypass, or is not a valid command name, it is ignored. |
|
Since updating my repo with recent commits for the PR, I have found that some of the new WC commands which used to work fine, now have issues. I will switch this PR to a draft for the time being, until I figure out why that is. |
|
There was no issue, I'm just a dumb dumb who forgot to run the build command |
|
Thank you for the great PR! |
| 'Offers', | ||
| 'StoreMirrors', | ||
| 'PendingRoots', | ||
| 'Plugins', |
| }), | ||
|
|
||
| addMissingFiles: mutation(build, DataLayer, 'addMissingFiles', { | ||
| invalidatesTags: (_result, _error, { ids }) => [{ type: 'Files', ids }], |
There was a problem hiding this comment.
According to https://redux-toolkit.js.org/rtk-query/usage/automated-refetching#invalidating-tags, invalidateTags wouldn't recognize ids property here.
The type of invalidateTags is either {type: string; id?: string|number}, {type: string}, or just string.
So I think this line should be:
invalidateTags: {_result, _error, { ids }) => ids.map(id => ({type: 'Files', id}))
| }), | ||
|
|
||
| cancelOffer: mutation(build, DataLayer, 'cancelOffer', { | ||
| invalidatesTags: (_result, _error, { tradeId }) => [{ type: 'Offers', tradeId }], |
There was a problem hiding this comment.
The same as above. invalidateTags won't accept tradeId as a tag id. So this should be:
invalidatesTags: (_result, _error, { tradeId }) => [{ type: 'Offers', id: tradeId }],
| }), | ||
|
|
||
| clearPendingRoots: mutation(build, DataLayer, 'clearPendingRoots', { | ||
| invalidatesTags: (_result, _error, { storeId }) => [{ type: 'PendingRoots', storeId }], |
| @@ -142,6 +142,10 @@ export const fullNodeApi = apiWithTag.injectEndpoints({ | |||
| getFeeEstimate: query(build, FullNode, 'getFeeEstimate', { | |||
| providesTags: [{ type: 'FeeEstimate' }], | |||
| }), | |||
|
|
|||
| pushTx: mutation(build, FullNode, 'pushTx', { | |||
| invalidatesTags: [{ type: 'Transactions', id: 'LIST' }], | |||
There was a problem hiding this comment.
I think Transaction(singular) is better than Transactions (plural).
Need to add Transaction tag name to Line#10:
const apiWithTag = api.enhanceEndpoints({ addTagTypes: ['BlockchainState', 'FeeEstimate', 'FullNodeConnections'] });
| @@ -167,6 +201,7 @@ export const { | |||
| useGetDIDNameQuery, | |||
| useSetDIDNameMutation, | |||
| useGetDIDRecoveryListQuery, | |||
| useUpdateDIDMetadataMutation, | |||
| useGetDIDInformationNeededForRecoveryQuery, | |||
| useGetDIDCurrentCoinInfoQuery, | |||
| useGetDIDInfoQuery, | |||
There was a problem hiding this comment.
usePushTxMutationis missing in full node hooks.useGetDIDMetadataQueryis missing in wallet hooksuseMintBulkMutationis missing in wallet hooks
|
|
||
| updateDIDMetadata: mutation(build, DID, 'updateDidMetadata', { | ||
| invalidatesTags: (_result, _error, { walletId }) => [ | ||
| { type: 'DIDInfo', id: walletId }, |
There was a problem hiding this comment.
The type of id with tag DIDInfo should be coinId.
I don't think this's appropriate to be here.
| // }), | ||
|
|
||
| getDIDMetadata: query(build, DID, 'getDidMetadata', { | ||
| providesTags: (result, _error, { walletId }) => (result ? [{ type: 'DIDMetadata', id: walletId }] : []), |
There was a problem hiding this comment.
The tag name DIDMetadata should be added to line#10 tagTypes array.
| { type: 'DIDInfo', id: walletId }, | ||
| { type: 'DIDCoinInfo', id: walletId }, | ||
| { type: 'Wallets', id: walletId }, | ||
| { type: 'DIDWallet', id: walletId }, |
There was a problem hiding this comment.
{ type: 'DIDMetadata', id: walletId} should be added.
Added a walletconnect endpoints for almost all DID and Datalayer commands, and nft_mint_bulk and push_tx to enable bulk minting via WC, and creating feature rich dapps.