Update blsjs.d.ts #448
Closed
Update blsjs.d.ts #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated blsjs.d.ts type inside the G1Element generator to return G1Element and not G2Element, or is this correct ?
Pull Request Test Coverage Report for Build 7634832904
💛 - Coveralls |
|
'This PR has been flagged as stale due to no activity for over 60 |
ChiaMineJP
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Thank you for your PR.
blsjs.d.ts is just a generated code so you need to update the original cpp file which generates this declaration file.
https://github.com/Chia-Network/bls-signatures/blob/main/js-bindings/jsbindings.cpp#L67
|
Ah sorry. I'll close this pull request and open a new one with the correct fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated blsjs.d.ts type inside the G1Element generator to return G1Element and not G2Element, or is this already correct ?