Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for GO #297

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

shotonoff
Copy link

Motivation

Since there is no go-bindings for this library, we (Dash) decided to add them here.

Overview

This PR is the implementation of GO bindings for the chia-bls library.

What was done

There was added bindings for all basic components:

  • Schemes (Basic, Aug, Pop)
  • PrivateKey
  • G1 and G2 elements

@hoffmang9
Copy link
Member

Happy to get this in once it's passing. Anything we can do to help?

@mariano54
Copy link
Contributor

We should probably merge this is before we add any new features

@mariano54
Copy link
Contributor

@xdustinface do you think we can merge this?

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@justinengland
Copy link
Member

@xdustinface want to double check you opinion here, can this be merged?

@github-actions github-actions bot removed the stale-pr label Apr 26, 2023
@xdustinface
Copy link
Contributor

Seems to be good to be merged yes, if we can keep it maintained and up to date? Even though i worked with this bindings before and im somewhat familiar with them i want to point out thats been a while and im not really into go, it was my only insight into it.

Also i guess, its been a too long time since this was opened, sorry for not replying here earlier.. :/ But we should probably have the go version and dependencies adjusted here, maybe. @shotonoff Any thoughts on this?

@xdustinface
Copy link
Contributor

xdustinface commented Jun 16, 2023

Reopening to rerun CI after some recent changes here.

@xdustinface xdustinface reopened this Jun 16, 2023
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5290440323

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.151%

Totals Coverage Status
Change from base Build 5283898189: 0.0%
Covered Lines: 1642
Relevant Lines: 1744

💛 - Coveralls

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants