Views Sort Plugin Generator #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chi-teck
reviewed
Nov 4, 2018
| /** | ||
| * Implements d8:plugin:views:sort command. | ||
| */ | ||
| class Style extends BaseGenerator { |
There was a problem hiding this comment.
The class name should Sort I presume.
manuee
reviewed
Jan 25, 2019
| class Style extends BaseGenerator { | ||
|
|
||
| protected $name = 'd8:plugin:views:sort'; | ||
| protected $description = 'Generates views sort plugin'; |
There was a problem hiding this comment.
Suggested change
| protected $description = 'Generates views sort plugin'; | |
| protected $description = 'Generates a views sort plugin'; |
manuee
reviewed
Jan 25, 2019
| protected function defineOptions() { | ||
| $options = parent::defineOptions(); | ||
| return $options; | ||
| } |
There was a problem hiding this comment.
Do we really need the defineOptions() method defined?
manuee
reviewed
Jan 25, 2019
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected $usesRowPlugin = TRUE; |
There was a problem hiding this comment.
I believe this is for sytle plugins only.
manuee
reviewed
Jan 25, 2019
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected $usesRowClass = TRUE; |
There was a problem hiding this comment.
I believe this is for sytle plugins only.
manuee
reviewed
Jan 25, 2019
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function buildOptionsForm(&$form, FormStateInterface $form_state) { |
There was a problem hiding this comment.
This method is an exact copy of SortPluginBase::buildOptionsForm(), I dont think we need to add it to the generated plugin.
manuee
suggested changes
Jan 25, 2019
|
Seems not many people interested in this generator. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.