Fixing Dollar Sign Escape #4363
Conversation
|
@Algorithm5838 is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
|
Your build has completed! |
|
quantizor/markdown-to-jsx#485 (comment) |
|
Unfortunately, I am unfamiliar with it, maybe others can help out. I just fixed the inconsistent escaping. |
app/components/markdown.tsx
Outdated
|
|
||
| return escapedText; | ||
| if (!isInCodeBlock) { | ||
| return line.replace(/(?<!`.*|\\)\$\d+([,.](\d+[,.])?\d+)?(?!.*\$\B)(?!.*`)/g, '\\$&'); |
There was a problem hiding this comment.
you may need to handle inside single backtick, table as well
There was a problem hiding this comment.
Thank you for your input. It does handle inside single backticks, unless one used a backtick in one line and another in the next line. Also, it does handle tables as well.
There was a problem hiding this comment.
How about this?
function escapeDollarNumber(text: string): string {
let isInCode = false;
return text.split('\n').map(line => {
if (line.trim() === '```' || line.trim() === '`') {
isInCode = !isInCode;
return line;
}
if (!isInCode) {
return line.replace(/(?<!`.*|\\)\$\d+([,.](\d+[,.])?\d+)?(?!.*\$\B)(?!.*`)/g, '\\$&');
} else {
return line;
}
}).join('\n');
}
There was a problem hiding this comment.
Thank you for your input. It does handle inside single backticks, unless one used a backtick in one line and another in the next line. Also, it does handle tables as well.
However, it still doesn't handle properly in your deployment
There was a problem hiding this comment.
I see. I will try to fix it.
Thank you.
app/components/markdown.tsx
Outdated
| return line; | ||
| } | ||
| if (!isInCode) { | ||
| return line.replace(/(?<!\\)\$\d+([,.](\d+[,.])?\d+)?(?!.*\$\B)(?!`+)/g, '\\$&'); | ||
| if (!isInMultilineCode) { |
There was a problem hiding this comment.
it's better
I think it should be fine for inside a table
There was a problem hiding this comment.
I just made another edits. The previous one had issues rendering latex. Check the new one. Hopefully there are no more issues.
| return inlineCode; | ||
| if (!isInBlockCode) { | ||
| return line.split(/(`.*?`)/g).map((segment, index) => { | ||
| if (index % 2 === 0) { |
There was a problem hiding this comment.
now it only handle correctly for left but not the right one
|
😄 |
app/components/markdown.tsx
Outdated
| @@ -109,7 +109,7 @@ function escapeDollarNumber(text: string): string { | |||
| if (!isInBlockCode) { | |||
| return line.split(/(`.*?`)/g).map((segment, index) => { | |||
| if (index % 2 === 0) { | |||
| return segment.replace(/(?<!\\)\$\d+([,.](\d+[,.])?\d+)?(?!.*\$\B)/g, '\\$&'); | |||
| return segment.replace(/(?<!\\)\$\d+([,.](\d+[,.])?\d+)?(?!.*\$\.)/g, '\\$&'); | |||
There was a problem hiding this comment.
Unfortunately, there is a new issue with: $1$, or any other number. It always escapes numbers. I will look into it.
There was a problem hiding this comment.
Unfortunately, there is a new issue with:
$1$, or any other number. It always escapes numbers. I will look into it.
@Algorithm5838 you right
here is the pattern for a test
$1$ $1$
$1 $2 $3 $3
`$1` $2 $3 `$4`
$x$ $hello world$ $x$ $1 $2 $3 $4
$x$ $hello world$ $x$ $1 $2 $3 $4 $x$ $hello world$ $x$
$1 $2 $3 $4 $x$
$1 2 $3 $4 $5
Improve the implementation of the dollar sign escape to address the issues with LaTeX.
Update: Done and ready for merge.