Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't use a venv for either GitHub Actions or CircleCI #7102

Merged
merged 9 commits into from Jun 16, 2022

Conversation

makyen
Copy link
Contributor

@makyen makyen commented Jun 16, 2022

Upon additional testing, it was seen that there needed to be more done in each CI run in order to make sure that a cache of the venv stayed at the most recent versions of our sub-dependencies without exceeding the versions required for our explicit requirements. The extra steps are required because pip doesn't update sub-dependencies of explicitly specified dependencies, unless required. Doing the extra steps cost enough time such that using a venv is, at best, neutral with respect to the amount of time required for installing all of the requirements from cached copies of the package downloads. In multiple cases, using the cached venv actually took longer. The entire point of using a venv in our CI was that fully caching the installed dependencies resulted in a savings in the run time for the CI tests. Without there being a time savings, there isn't a point to using a venv.

So, this PR removes the use of venv from both GitHub Actions and CircleCI. It implements/re-implements caching for the main pip download cache.

Resolves #7100

@makyen makyen merged commit 1803aea into master Jun 16, 2022
@makyen makyen deleted the Mak-CI-use-full-Python-version-for-env-cache-key branch June 16, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test failures in Github Actions for Python 3.10
1 participant