Added threadId to Element #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayaankvad
commented
May 19, 2024
| @@ -114,7 +114,7 @@ async def get_thread_author(self, thread_id: str): | |||
| return "admin" | |||
|
|
|||
| async def list_threads( | |||
| self, pagination: cl_data.Pagination, filter: cl_data.ThreadFilter | |||
| self, pagination: cl_data.Pagination, filters: cl_data.ThreadFilter | |||
There was a problem hiding this comment.
Fixed error:
Parameter 'filters' has been renamed to 'filter' in overriding 'TestDataLayer.list_threads' method PylintW0237:arguments-renamed
Method "list_threads" overrides class "BaseDataLayer" in an incompatible manner
Parameter 3 name mismatch: base parameter is named "filters", override parameter is named "filter" Pylance reportIncompatibleMethodOverride
__init__.py(118, 15): Overridden method
mayaankvad
commented
May 19, 2024
This reverts commit dd5e4b5.
mayaankvad
commented
May 19, 2024
There was a problem hiding this comment.
git hook pnpm lint-staged has made changes everywhere here to add the logger on a new line.
willydouhard
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this as prep for a custom data layer. This change will allow more flexible custom data layers, especially document ones like Dynamo.
Currently you can get the threadId in create element:
This change adds the thread_id param to delete element:
All current data layers have been modified to accept the new param. The Custom Data Layer API Docs will need to be updated. Should not be a breaking change but should be a mention in a migration guide.