[Django Upgrade] [ ENG-3948] Fix Draft Registration Serializer DRF Issues #10034

Johnetordoff · 2022-08-26T17:24:55Z

Purpose

The Django/DRF upgrade created a complex inheirence issue where method names were resolved differently for subclassed serializer. This PR fixes those methods to work with tests.

Changes

Notes

Revelent disscussion:
encode/django-rest-framework#5798

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

…OpenScience/osf.io into django-3-DRF-serializer * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: (23 commits) Fix system check warnings for django admin Add migrations for django upgrade base fixes Comment out admin permissions that clash with built-in "view" ones Add/Enable missing templates and middlewares in api settings Fix django CORS whitelist settings due to orgin definition update Add required on_delete=CASCADE (default) to FKs missing it Make fields defined on typedmodels subclasses nullable Upgrade django to 3.2.15 (and related dependencies) Fix typo Prevent errors in Keen-less environments Add missing defaults Bump DEFAULT_API_VERSION to 2.20 Improve import formatting Improve header comparison Add PLOS Metrics command - Update celery config/queues Fix local cookie samesite config and use 'Lax' instead of 'None' Add task to celery settings Pass and load Identifier ID instead of instance Bump version and update changelog Registration Resources (CenterForOpenScience#10042) ...

api/base/exceptions.py

api/files/views.py

api/nodes/serializers.py

…OpenScience/osf.io into django-3-DRF-serializer * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Fix CORS for ORIGINS_WHITELIST Use prefetch instead of Django include Fix session cookie encoding/decoding by using ensure_str() Use JsonField from django.db.models and django.forms Use default truthy and falsy values from upgraded DRF 3.13.1 Enable django.contrib.sessions.middleware.SessionMiddleware Fix django cache table creation

api/draft_registrations/serializers.py

…OpenScience/osf.io into django-3-DRF-serializer * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Remove QuickFile check from get_serializer_class for FileDetail view Rename auto generated migration for django3 upgrade fixes Bump NR Agent version

cslzchen · 2022-09-13T18:24:25Z

This PR has been replaced with #10058

Johnetordoff changed the base branch from develop to feature/django_upgrade August 26, 2022 17:25

Johnetordoff force-pushed the django-3-DRF-serializer branch 7 times, most recently from b879ab1 to 1e1a15f Compare August 27, 2022 15:02

adjust for new serializer inheritance scheme for the new version of DFR

7c30699

Johnetordoff force-pushed the django-3-DRF-serializer branch from 1e1a15f to 7c30699 Compare August 27, 2022 16:06

Johnetordoff marked this pull request as ready for review August 29, 2022 17:58

cslzchen force-pushed the feature/django_upgrade branch from c03627b to 9e9c487 Compare September 9, 2022 19:24

cslzchen changed the title ~~Fix Draft Registration Serializer DRF issues for Django Upgrade~~ [Django Upgrade] [ ENG-3498] Fix Draft Registration Serializer DRF Issues Sep 9, 2022

cslzchen force-pushed the django-3-DRF-serializer branch 2 times, most recently from 12e9433 to 51ba98e Compare September 9, 2022 20:23