Skip to content

Commit

Permalink
Fixed navbar unwatched scroll behavior
Browse files Browse the repository at this point in the history
* Fixes saadeghi#875
  • Loading branch information
CapitaineToinon committed Aug 9, 2022
1 parent b6890d7 commit a0f829a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 12 deletions.
18 changes: 9 additions & 9 deletions src/docs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/docs/package.json
Expand Up @@ -33,7 +33,7 @@
},
"dependencies": {
"color": "^4.2.1",
"daisyui": "^2.11.1",
"daisyui": "^2.22.0",
"emoji-unicode": "^2.0.1",
"lodash.debounce": "^4.0.8",
"nanoid": "^3.3.1",
Expand Down
8 changes: 6 additions & 2 deletions src/docs/src/routes/__layout.svelte
Expand Up @@ -42,6 +42,10 @@
onMount(() => {
parseContentScroll()
parseSidebarScroll()
// fix for https://github.com/sveltejs/kit/issues/3501
// todo: upgrade to latest svelte-kit version instead
document.body.removeAttribute("tabindex")
})
afterNavigate(() => {
Expand All @@ -66,13 +70,13 @@

<div class={`bg-base-100 drawer ${pagesThatDontNeedSidebar.includes($page.url.pathname) ? "" : "drawer-mobile"}`}>
<input id="drawer" type="checkbox" class="drawer-toggle" bind:checked />
<div bind:this={drawercontent} on:scroll={parseContentScroll} class={`drawer-content`} style="scroll-behavior: smooth; scroll-padding-top: 5rem;">
<div bind:this={drawercontent} on:scroll={parseContentScroll} class={`drawer-content`} style="scroll-behavior: smooth;">
<Navbar {drawerContentScrollY} />
<div class={`${pagesThatDontNeedSidebar.includes($page.url.pathname) ? "" : "p-6 pb-16"}`}>
<slot />
</div>
</div>
<div class="drawer-side" style="scroll-behavior: smooth; scroll-padding-top: 5rem;" bind:this={drawersidebar} on:scroll={parseSidebarScroll}>
<div class="drawer-side" style="scroll-behavior: smooth;" bind:this={drawersidebar} on:scroll={parseSidebarScroll}>
<label for="drawer" class="drawer-overlay" />
<aside class="bg-base-200 w-80">
<Sidebar {closeDrawer} {openDrawer} {drawerSidebarScrollY} />
Expand Down

0 comments on commit a0f829a

Please sign in to comment.