Fix i18n lookup for unauthorized message #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking up `nil` doesn't make sense. So instead, we treat the first key in the `keys` array as the actual desired key and the remainder as potential fallbacks for `default`.
|
Thank you @clemens, I think we need a test here to proove that the issue is really solved, so a test that would actually fail without your changes and passes with them. Thanks for your contribution! Really appreciated. |
|
What do you have in mind for that test? A mock that expects a call with a certain key? Otherwise we'd have to test against a specific version of i18n – which seems questionable. |
coorasse
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415 without relying on specific i18n version.
Inspired by https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/base.rb#L173-L189.