Update react-scripts to 5.0.0 #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
nickclyde
changed the title
nickclyde
requested review from
nathancrtr,
emmastephenson,
jdorothy and
rin-skylight
|
This should be ready for review now! There were 8 UI changes in Chromatic, but I honestly couldn't tell the difference by visual inspection, so I just went ahead and accepted them. I'm gonna go ahead and deploy to dev and do some smoke testing to make sure nothing looks off. |
nathancrtr
reviewed
Jan 14, 2022
| @@ -48,7 +48,7 @@ export const useFacilityValidation = (facility: Facility) => { | |||
| orderingProviderIsRequired: requiresOrderProvider(facility.state), | |||
| }, | |||
| }); | |||
| } catch (e) { | |||
| } catch (e: any) { | |||
There was a problem hiding this comment.
Thanks for getting rid of these red squiggles in VSCode 馃檪
nathancrtr
reviewed
Jan 14, 2022
| @@ -4,12 +4,12 @@ describe("isValidCLIANumber::string -> boolean", () => { | |||
| test("valid number returns `true`", () => { | |||
| const cliaNumber = "12D4567890"; | |||
|
|
|||
| expect(isValidCLIANumber(cliaNumber)).toBe(true); | |||
| expect(isValidCLIANumber(cliaNumber, "VA")).toBe(true); | |||
nathancrtr
approved these changes
Jan 14, 2022
rin-skylight
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Background Info
react, 17.0.2. However, React 18 is in rc and release is imminent. I will be keeping an eye out to see if it releases in the next few days.react-scripts, along with a slew of other packages that need updating along with it, includinguswdsChanges Proposed
react-scriptsto 5.0.0dart-sassand use mixins at the component level聽#1681. I decided to remove since it reduces our build complexity, and we don't really have any sass/uswds experts on the team anymore, so it seems unlikely that we will use mixins anyways.react-scriptsupgradedjestreact-scriptsalso updatedeslintto 8.x, needed to update some eslint plugins and change some eslint configuration, including adding a typescript parser for it, see more hereuswdsto 2.13.0 as well. Along with this I had to change the way we import some uswds iconssassto 1.47.0. Along with theuswdsupgrade this seems to have finally cleared out all the useless deprecation warnings and changelog notes we get when running the frontend!! 馃帀typescriptto 4.5.4, and fixed a whole bunch of ts errors in our testsAdditional Information
Screenshots / Demos
Checklist for Author and Reviewer
Infrastructure
terraform-planjob inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!Design
test,dev, orpentestand smoke-tested by both the engineering and design teamsContent
Support
Testing
Changes are Backwards Compatible
(including re-granting permission to the no-PHI user if need be)
./gradlew liquibaseRollbackSQLorliquibaseRollbackSecurity
Cloud
test,dev, orpentestenvironment for verification