Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13538: send original filename format report_id-original_name #14400

Merged
merged 2 commits into from
May 15, 2024

Conversation

mkalish
Copy link
Collaborator

@mkalish mkalish commented May 14, 2024

This PR updates the name format for topics with isSendOrginal=true

Test Steps:

  1. Execute
curl --location 'http://localhost:7071/api/reports' \
--header 'client: ignore.ignore-elr-elims' \
--header 'Content-Type: application/hl7-v2' \
--header 'x-functions-key: 09xifjf....444s' \
--header 'payloadname: external-name-test.hl7' \
--data 'MSH|^~\&|MEDITECH^2.16.840.1.114222.4.3.2.2.1.321.111^ISO|COCAA|DCEED.ELR^2.16.840.1.114222.4.1.144.2.5^ISO|CDPHE^2.16.840.1.114222.4.1.144^ISO|20280808152805+0000||ORU^R01^ORU_R01|MT_COCAA_ORU_AAPHELR.1.6214638|P|2.5.1
SFT|MEDITECH, Inc.^L^^^^MEDITECH&1.3.6.1.4.1.24310&ISO^XX^^^MEDITECH|5.67|Laboratory Applicati|20210810||20210810000000+0000
PID|1||100001^^^MEDITECH&2.16.840.1.114222.4.3.2.2.1.321.111&ISO^MR^COCAA~285-64-4175^^^MEDITECH&2.16.840.1.114222.4.3.2.2.1.321.111&ISO^SS^COCAA~X605236^^^MEDITECH&2.16.840.1.114222.4.3.2.2.1.321.111&ISO^PI^COCAA~E40014904640^^^MEDITECH&2.16.840.1.114222.4.3.2.2.1.321.111&ISO^AN^COCAA||^^^^^^L|||M||2106-3^https://www.hl7.org/fhir/v2/0005/^HL70005^W^White^L^2.5.1|^^^NM^^USA^H||^PRN^PH^^1^^^^^^^|^WPN^PH^^1^^^^Business^^^||S|NOE^Nonreligious^HL70006|||||N^https://www.hl7.org/fhir/v2/0189/^HL70189^2^Not Hispanic or Latin^L^2.5.1||||||||N|||20210809145200+0000|COCAA|337915000^Homo sapiens (organism)^SCT^Human^Human^L
ORC|RE|09339017^M12776123.1^2.16.840.1.114222.4.1.144^ISO||21:AA:B0029251S^M12776123^2.16.840.1.114222.4.1.144^ISO||N|||20280808092800+0000|||^^^^^^^^&2.16.840.1.113883.4.6&ISO^^^^NPI||^WPN^PH^^1^303^4362727^^Hospital Line^^^+1 303 436 2727|20210803235000+0000||TMCA, SOUTH CAMPUS||||TMCA, SOUTH CAMPUS^L^^^^TMCA, SOUTH CAMPUS&2.16.840.1.114222.4.1.144&ISO^XX^^^06D0055551|1501 S. POTOMAC^^AURORA^IG^80012^USA^B^^MD
OBR|1|09339017^M12776123.1^2.16.840.1.114222.4.1.144^ISO||600-7^Bacteria identified in Blood by Culture^LN^BCEXT^EXTENDED BLOOD CULTURE^L||||20280802085201+0000||ER|||SEPTIC SHOCK|||^^^^^^^^&2.16.840.1.113883.4.6&ISO^^^^NPI|^WPN^PH^^1^303^4362727^^Hospital Line^^^+1 303 436 2727|21:AA:B0029251Sm12776123|09339017||TMCA, SOUTH CAMPUS|20210810122500+0000|||P||||||R6521^SEVERE SEPSIS WITH SEPTIC SHOCK^I10^R6521^SEVERE SEPSIS WITH SEPTIC SHOCK^I10
OBX|1||600-7^Bacteria identified in Blood by Culture^LN^BCEXT^EXTENDED BLOOD CULTURE^L|1.1|||||||C|||20280802085201+0000|MCOE^ROSE MEDICAL CENTER (MCOE)^LB||||20280807223601+0000||||ROSE MEDICAL CENTER (MCOE)^L|4567 E. NINTH AVENUE^^DENVER^IG^80220^USA^B^^S|1033122247^Chahal^Shalini^^^Dr.^MD^^RML^L^^^FI^ROSE MEDICAL CENTER'
  1. Verify that a report shows up in the sftp directory that looks like <SOME_UUID>-external-name-test.hl7

Changes

  • For isSendOriginal=true sets the file name to {report.id}-{externalname}

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Specific Security-related subjects a reviewer should pay specific attention to

@mkalish mkalish marked this pull request as ready for review May 14, 2024 20:31
@mkalish mkalish requested a review from a team as a code owner May 14, 2024 20:31
Copy link

github-actions bot commented May 14, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented May 14, 2024

Test Results

1 172 tests  ±0   1 168 ✅ ±0   7m 14s ⏱️ +5s
  147 suites ±0       4 💤 ±0 
  147 files   ±0       0 ❌ ±0 

Results for commit 9a2c99e. ± Comparison against base commit 0ca06c5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 14, 2024

Integration Test Results

 62 files   62 suites   33m 33s ⏱️
394 tests 384 ✅ 10 💤 0 ❌
397 runs  387 ✅ 10 💤 0 ❌

Results for commit 9a2c99e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@brick-green brick-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you done did it

@mkalish mkalish added the platform Platform Team label May 15, 2024
@mkalish mkalish enabled auto-merge (squash) May 15, 2024 16:24
Copy link

sonarcloud bot commented May 15, 2024

@mkalish mkalish merged commit 2122c04 into master May 15, 2024
16 checks passed
@mkalish mkalish deleted the platform/kalish/13538-malformed-delivered-filenames branch May 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants