Implemented destination filter #14399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Test Results1 197 tests 1 193 ✅ 6m 30s ⏱️ Results for commit 467887f. ♻️ This comment has been updated with latest results. |
Integration Test Results 62 files 62 suites 33m 23s ⏱️ Results for commit 467887f. ♻️ This comment has been updated with latest results. |
thetaurean
force-pushed
the
platform/thetaurean/13691-destination-filter
branch
from
3467c90
to
bc3664f
Compare
thetaurean
force-pushed
the
platform/thetaurean/13691-destination-filter
branch
from
bc3664f
to
a176333
Compare
mkalish
reviewed
May 15, 2024
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
mkalish
reviewed
May 15, 2024
prime-router/src/main/resources/db/migration/V68__add_split_routing.sql
Outdated
Show resolved
Hide resolved
thetaurean
force-pushed
the
platform/thetaurean/13691-destination-filter
branch
from
5db20cc
to
f2f8a38
Compare
thetaurean
force-pushed
the
platform/thetaurean/13691-destination-filter
branch
from
d94ead9
to
8197bdd
Compare
thetaurean
force-pushed
the
platform/thetaurean/13691-destination-filter
branch
from
cb172f8
to
582c5a9
Compare
…ation-filter' into platform/thetaurean/13691-destination-filter
mkalish
reviewed
May 22, 2024
There was a problem hiding this comment.
Maybe a new file for these?
mkalish
approved these changes
May 22, 2024
prime-router/src/main/kotlin/azure/observability/event/ReportRouteEvent.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/azure/observability/event/ReportRouteEvent.kt
Outdated
Show resolved
Hide resolved
prime-router/src/main/kotlin/fhirengine/engine/FHIRDestinationFilter.kt
Outdated
Show resolved
Hide resolved
…/13691-destination-filter
…/13691-destination-filter
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the transition to split routing. It implements the destination filter function and adds a stubbed receiver filter function that should hopefully avoid the need for another migration.
Test Steps:
Changes
FHIRDestinationFilterandFHIRReceiverFiltertask_actiontype to include values for new functionsTASKtable to includedestination_filtered_atandreceiver_filtered_attimestampsChecklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?npm run lint:write?Linked Issues
To Be Done
FHIRRouterdb tests