Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend dotenv #14396

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

backend dotenv #14396

wants to merge 17 commits into from

Conversation

jpandersen87
Copy link
Collaborator

@jpandersen87 jpandersen87 commented May 14, 2024

This PR is a quality of life improvement to how environment variables are handled for local gradle tasks (these variables are NOT used in the prime-router application being built when it is ran).

  • All environment variables from docker yaml and gradle build moved to .env file
    • host-specific overrides that are used in gradle build have a host (capitalization depending on existing pattern) prefix
  • build fun loadDotEnv added
    • creates map variable of the following in priority least to greatest:
      • .env
      • .env.local
      • host environment
      • project properties
    • applies specific overrides (docker hostname to localhost) to particular variables if one wasn't supplied manually via host environment or project properties
  • build vault fun updated to create new map (applying vault variables on top) from provided map
  • env var accesses replaced with dotEnv
  • Prime-router .gitignore initialized using the root .gitignore
    • Entry ignoring .env.local / .env.*.local files added to .gitignore
  • prime-router specific .gitignore entries removed from root .gitignore
  • docker compose usages across github actions, un-deprecated documentation, scripts, etc. updated to use dotenv file

@jpandersen87 jpandersen87 self-assigned this May 14, 2024
Copy link

github-actions bot commented May 14, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented May 14, 2024

Test Results

0 tests   - 1 172   0 ✅  - 1 168   0s ⏱️ - 6m 57s
0 suites  -   147   0 💤  -     4 
0 files    -   147   0 ❌ ±    0 

Results for commit 281cc93. ± Comparison against base commit eca9466.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 14, 2024

Integration Test Results

0 files   -  62  0 suites   - 62   0s ⏱️ - 33m 29s
0 tests  - 394  0 ✅  - 384  0 💤  - 10  0 ❌ ±0 
0 runs   - 397  0 ✅  - 387  0 💤  - 10  0 ❌ ±0 

Results for commit 281cc93. ± Comparison against base commit eca9466.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant