Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Encryption for files sent to NATUS LA #14325

Merged
merged 20 commits into from
May 21, 2024
Merged

Add Encryption for files sent to NATUS LA #14325

merged 20 commits into from
May 21, 2024

Conversation

oslynn
Copy link
Collaborator

@oslynn oslynn commented May 6, 2024

This PR adds Encryption for files sent to NATUS LA

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@oslynn oslynn self-assigned this May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

Test Results

1 181 tests  +1   1 177 ✅ +1   7m 17s ⏱️ +9s
  150 suites +1       4 💤 ±0 
  150 files   +1       0 ❌ ±0 

Results for commit 6e4bf5e. ± Comparison against base commit dca23dc.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
prime-router/src/main/kotlin/transport/RESTTransport.kt Outdated Show resolved Hide resolved
prime-router/src/main/kotlin/transport/RESTTransport.kt Outdated
}

@Throws(CertificateException::class)
override fun checkClientTrusted(arg0: Array<X509Certificate?>?, arg1: String?) {

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AY9QPqvWU7G3BBA3XbY9-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=CDCgov_prime-data-hub&issues=AY9QPqvWU7G3BBA3XbY9&open=AY9QPqvWU7G3BBA3XbY9&pullRequest=14325">SonarCloud</a></p>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

Integration Test Results

 62 files   62 suites   32m 45s ⏱️
395 tests 385 ✅ 10 💤 0 ❌
398 runs  388 ✅ 10 💤 0 ❌

Results for commit 6e4bf5e.

♻️ This comment has been updated with latest results.

@oslynn oslynn added etor onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. labels May 9, 2024
JohnNKing
JohnNKing approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@JohnNKing JohnNKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here

@oslynn oslynn requested a review from a team as a code owner May 15, 2024 20:19
victor-chaparro
victor-chaparro reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one small comment

prime-router/src/main/kotlin/transport/RESTTransport.kt Show resolved Hide resolved
@oslynn oslynn enabled auto-merge (squash) May 21, 2024 14:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@oslynn oslynn merged commit 9bbb1e5 into master May 21, 2024
15 of 16 checks passed
@oslynn oslynn deleted the oo/oslynn/12925/Add_Encryption_for_Files_send_To_NATUS branch May 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNKing JohnNKing JohnNKing approved these changes

@victor-chaparro victor-chaparro victor-chaparro approved these changes

@GilmoreA6 GilmoreA6 Awaiting requested review from GilmoreA6

@snesm snesm Awaiting requested review from snesm

@lucero-v lucero-v Awaiting requested review from lucero-v

Assignees

@oslynn oslynn

Labels
etor onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
PRIME ReportStream Engagement
Status: New items
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oslynn @JohnNKing @victor-chaparro