Merge pull request #8677 from CDCgov/josiahsiegel/update/action_node

frontend action read node version from file
CDCgov · Mar 10, 2023 · 249cdb6 · 249cdb6
2 parents b9f927e + 4ed86e3
commit 249cdb6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.github/actions/build-frontend/action.yml b/.github/actions/build-frontend/action.yml
@@ -25,10 +25,11 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Use Node.js ${{ matrix.node-version }} with yarn
+
+    - name: Use Node.js with yarn
       uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
       with:
-        node-version: "18.15"
+        node-version-file: 'frontend-react/package.json'
 
     - run: yarn install
       working-directory: frontend-react

diff --git a/.github/workflows/build_frontend.yaml b/.github/workflows/build_frontend.yaml
@@ -14,7 +14,7 @@ jobs:
     name: Pre Job
     runs-on: ubuntu-latest
     outputs:
-      has_react_change: ${{ steps.skip_check.outputs.frontend_react }}
+      has_react_change: ${{ steps.build_vars.outputs.has_react_change }}
       env_name: ${{ steps.build_vars.outputs.env_name }}
       version: ${{ steps.build_vars.outputs.version }}
     steps:
@@ -23,13 +23,6 @@ jobs:
       - name: Build vars
         id: build_vars
         uses: ./.github/actions/build-vars
-      - uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50
-        id: skip_check
-        with:
-          list-files: csv
-          filters: |
-            frontend_react:
-              - 'frontend-react/**'
 
   build_frontend_react:
     name: Build Frontend React