Skip to content

Commit

Permalink
Remove wrong-encoding tests
Browse files Browse the repository at this point in the history
Unfortunately gorakhargosh#703 cannot easily be backported, so we won't have this
functionality in the Python 2.7 / 3.5 branch unless someone reports
this as an issue.
  • Loading branch information
CCP-Aporia committed Jan 26, 2021
1 parent a3d1692 commit e20c2f7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
1 change: 0 additions & 1 deletion changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ Changelog
- [windows] ``winapi.BUFFER_SIZE`` now defaults to ``64000`` (instead of ``2048``) (`#700 <https://github.com/gorakhargosh/watchdog/pull/700>`_)
- [windows] Introduced ``winapi.PATH_BUFFER_SIZE`` (defaults to ``2048``) to keep the old behavior with path-realted functions (`#700 <https://github.com/gorakhargosh/watchdog/pull/700>`_)
- Use ``pathlib`` from the standard library, instead of pathtools (`#556 <https://github.com/gorakhargosh/watchdog/pull/556>`_)
- Allow file paths on Unix that don't follow the file system encoding (`#703 <https://github.com/gorakhargosh/watchdog/pull/703>`_)
- Removed the long-time deprecated ``events.LoggingFileSystemEventHandler`` class, use ``LoggingEventHandler`` instead
- Thanks to our beloved contributors: @SamSchott, @bstaletic, @BoboTiG, @CCP-Aporia

Expand Down
19 changes: 0 additions & 19 deletions tests/test_emitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,25 +180,6 @@ def test_close():
assert event_queue.empty()


@pytest.mark.flaky(max_runs=5, min_passes=1, rerun_filter=rerun_filter)
@pytest.mark.skipif(
platform.is_darwin() or platform.is_windows(),
reason="Windows and macOS enforce proper encoding"
)
def test_create_wrong_encoding():
start_watching()
open(p('a_\udce4'), 'a').close()

event = event_queue.get(timeout=5)[0]
assert event.src_path == p('a_\udce4')
assert isinstance(event, FileCreatedEvent)

if not platform.is_windows():
event = event_queue.get(timeout=5)[0]
assert os.path.normpath(event.src_path) == os.path.normpath(p(''))
assert isinstance(event, DirModifiedEvent)


@pytest.mark.flaky(max_runs=5, min_passes=1, rerun_filter=rerun_filter)
def test_delete():
touch(p('a'))
Expand Down

0 comments on commit e20c2f7

Please sign in to comment.