auto-tag support #651
Merged
auto-tag support #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. (#650) Further make clear in the documentation that `bash` is used to execute the fixture scripts, previously it wasn't even implied and got lost in history.
Byron
force-pushed
the
adjustments-for-cargo
branch
from
eace6c5
to
de66815
Compare
This works by trying to execute the file directly, and on failure, use 'bash' as interpreter. That way we are finally able to support a wider variety of fixture generators and make the crate more useful to a wieder audience.
Byron
force-pushed
the
adjustments-for-cargo
branch
4 times, most recently
from
eb8144a
to
ae35c60
Compare
This flag always has to be added by the caller based on configuration.
Byron
force-pushed
the
adjustments-for-cargo
branch
4 times, most recently
from
16bbcfd
to
8be4f1b
Compare
…-tag`. One can also check for its availability using `fetch::Arguments::can_use_include_tag()`. Further there was a bugfix that assues V1 capabilities are correctly interpreted to support include-tag.
Byron
force-pushed
the
adjustments-for-cargo
branch
2 times, most recently
from
09b6f27
to
0cefb55
Compare
That way it's clear if it should or shouldn't fetch included/reachable tags automatically. The default setting for this is to include tags, similar to `git`. The `fetch_tags()` accessor allows to query this information, and the `with_fetch_tags()` builder method allows to set the value comfortably right after creating the `Remote` instance. The `tagOpt` key will also be written as part of the remote's git configuration. Clone operations can set the `Tags` setting when configuring the remote in a callback. This also comes with a fix to assure that ref-updates aren't skipped just because there was no pack to receive. That way, locally missing refs or tags will automatically be put back.
Normally refspecs are coming from the configuration only, but now implied specs due to the implicit include-tag feature also matter.
That way we can allow the implementation to choose whether they need greatest speed at some cost or not. This also allows us to create a new thread-pool on each iteration as those who expect high cost or many files will likely chose to do that instead of single-threaded iteration, which nicely contains the threads needed and avoids keeping them alive as part of some global pool.
We only use parallel traversal where it matters most, namely loose object traversal which can be many objects in up to 256 folders. Being able to parallelize among them will be a noticable speedup well worth the cost (presumably). Ref traversals are single-threaded as we expect most refs in packed-refs anyway. Furthermore we can now consider parallel traversal safe as we don't use the global rayon pool anymore, something that can break any parallel iteration (and just a version of `jwalk` earlier it would deadlock).
Byron
force-pushed
the
adjustments-for-cargo
branch
from
0cefb55
to
35f7d59
Compare
This is the same as `git clone --no-tags`.
I don't know if the toolchain file works like that either, set a local override for now via `rustup override set 1.65`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
RemotetagOptkeys when writing aRemoteto git configurationfetch_tagsoption and figures out which tags (and their objects) are included in the pack to create themgix remote refmapmakes clear which specs are implicit, and we figure out if implicit specs should be forced (answer: no)include-tagUpdatevariantgix clonelearns--no-tagsExtras
refwalks as they are less likely to be numerous. Then letjwalkuse its own threadpool for each iteration to workaround deadlocking if there are not enough threads. Or fix the threading issue.For another PR
Issues